enuno/claude-command-and-control/validator-role-skill

Load context files:
- DEVELOPMENT_PLAN.md (overall plan)
- ARCHITECTURE.md (design specs)
- IMPLEMENTATION_PLAN.md (implementation details)

# Test Plan: [Feature Name]
 
## Test Strategy
-Unit Test Coverage Target: 95%
-Integration Test Coverage: All public APIs
-E2E Test Coverage: Critical user paths
-Performance Benchmarks: [Specific targets]
 
## Test Categories
 
### Unit Tests
**Component**: [Name]
-Test 1: [Scenario] - Expected: [Result]
-Test 2: [Scenario] - Expected: [Result]
-Test 3: [Edge case] - Expected: [Error handling]
 
### Integration Tests
**Integration Point**: [Name]
-Test 1: [Interaction scenario]
-Test 2: [Data flow validation]
-Test 3: [Error propagation]
 
### End-to-End Tests
**User Journey**: [Name]
-Test 1: [Happy path]
-Test 2: [Alternate path]
-Test 3: [Error scenarios]
 
## Test Data Requirements
[Fixtures, mocks, test databases needed]
 
## Performance Criteria
-Response time: < [X]ms
-Throughput: > [Y] requests/sec
-Memory usage: < [Z]MB
 
## Security Test Cases
-[ ] Input validation
-[ ] SQL injection protection
-[ ] XSS prevention
-[ ] Authentication bypass attempts
-[ ] Authorization boundary tests

// Example: Jest/JavaScript
describe('UserService', () => {
  describe('createUser', () => {
    it('should create user with valid data', async () => {
      // Arrange
      const userData = {
        email: 'test@example.com',
        password: 'SecurePass123!'
      };
      // Act
      const result = await userService.createUser(userData);
      // Assert
      expect(result).toHaveProperty('id');
      expect(result.email).toBe(userData.email);
      expect(result.password).not.toBe(userData.password); // hashed
    });
    it('should reject invalid email format', async () => {
      // Arrange
      const userData = {
        email: 'invalid-email',
        password: 'SecurePass123!'
      };
      // Act & Assert
      await expect(userService.createUser(userData))
        .rejects.toThrow('Invalid email format');
    });
    it('should reject weak password', async () => {
      // Arrange
      const userData = {
        email: 'test@example.com',
        password: '123'
      };
      // Act & Assert
      await expect(userService.createUser(userData))
        .rejects.toThrow('Password does not meet security requirements');
    });
  });
});

---
TO: Builder (or use builder-role-skill)
FEATURE: [Feature Name]
TEST_SPEC: TEST_PLAN.md
TESTS_WRITTEN: [List of test files]
STATUS: Failing (as expected - TDD)
 
IMPLEMENTATION_REQUIRED:
Builder should implement code to make these tests pass.
 
VALIDATION_CRITERIA:
-All unit tests passing
-Coverage >= 95%
-No security warnings
---

Load context files:
- IMPLEMENTATION_PLAN.md (what was built)
- PR description (change summary)
- Modified files list (scope of changes)

# Run all tests
npm test || pytest || mvn test || cargo test
 
# Generate coverage report
npm run coverage || pytest --cov --cov-report=html || mvn jacoco:report
 
# Run linter
npm run lint || flake8 || mvn checkstyle:check || cargo clippy
 
# Run security scan
npm audit || safety check || mvn dependency-check:check || cargo audit

# Validation Report: [Feature/PR Name]
 
## Test Execution Results
-Total Tests: [N]
-Passing: [N]
-Failing: [N]
-Skipped: [N]
-Duration: [X]s
 
## Coverage Analysis
-Overall Coverage: [X]%
-Line Coverage: [X]%
-Branch Coverage: [X]%
-Function Coverage: [X]%
 
**Coverage by Component**:
| Component | Coverage | Status |
|-----------|----------|--------|
| [Name] | [X]% | ✅ / ⚠️ / ❌ |
 
**Uncovered Areas**:
-File: [name], Lines: [X-Y] - Reason: [Why not covered]
 
## Code Quality
-Linting Issues: [N]
-Code Smells: [N]
-Complexity Warnings: [N]
-Duplication: [X]%
 
## Security Assessment
-Vulnerabilities Found: [N]
-Severity: [Critical/High/Medium/Low]
-Affected Packages: [List]
 
## Performance Validation
-Response Time: [X]ms (Target: <[Y]ms) ✅ / ❌
-Memory Usage: [X]MB (Target: <[Y]MB) ✅ / ❌
-Throughput: [X] req/s (Target: >[Y]) ✅ / ❌
 
## Overall Assessment
**Status**: ✅ APPROVED / ⚠️ APPROVED WITH CONCERNS / ❌ REJECTED
 
**Justification**:
[Detailed reasoning for decision]

## Code Review Comments
 
### Critical Issues (Must Fix)
1.**File: [name], Line: [X]**
   -Issue: [Description]
   -Impact: [Security/Functionality/Performance]
   -Recommendation: [How to fix]
 
### Suggestions (Should Consider)
1.**File: [name], Line: [X]**
   -Observation: [What could be improved]
   -Recommendation: [Alternative approach]
   -Benefit: [Why it's better]
 
### Positive Highlights
1.**File: [name]**
   -Excellent: [What was done well]
 
### Questions
1.**File: [name], Line: [X]**
   -Question: [What's unclear]
   -Context: [Why asking]

# Add approval comment to PR
gh pr review [PR-number] --approve --body "$(cat VALIDATION_REPORT.md)"
 
# Update status
echo "✅ Validation complete - APPROVED" >> MULTI_AGENT_PLAN.md

# Request changes
gh pr review [PR-number] --request-changes --body "$(cat VALIDATION_REPORT.md)"

---
TO: Builder (or use builder-role-skill)
PR: #[number]
STATUS: Changes Requested
VALIDATION_REPORT: VALIDATION_REPORT.md
PRIORITY_FIXES: [List critical issues]
REVALIDATION_REQUIRED: After fixes applied
---

# Find changed files
git diff --name-only main..HEAD
 
# Find tests related to changed files
grep -r "import.*[changed-file]" test/

# Run full test suite
npm test
 
# Run affected component tests specifically
npm test -- --testPathPattern=[component]
 
# Compare with baseline performance
npm run benchmark

# Regression Test Report: [Date]
 
## Changes Analyzed
-[File 1]: [Type of change]
-[File 2]: [Type of change]
 
## Tests Executed
-Total regression tests: [N]
-New failures: [N]
-Fixed issues: [N]
 
## Regression Detected
**None** / **Issues Found**:
 
1.**Test**: [Name]
   -Previous: PASS
   -Current: FAIL
   -Root Cause: [Analysis]
   -Action: [Revert / Fix / Accept]
 
## Recommendation
✅ Safe to proceed / ❌ Revert changes / ⚠️ Proceed with caution

# Security Validation Checklist: [Feature]
 
## Input Validation
-[ ] All user inputs validated
-[ ] Type checking implemented
-[ ] Length/size limits enforced
-[ ] Special characters sanitized
-[ ] SQL injection protected
-[ ] XSS prevention in place
 
## Authentication & Authorization
-[ ] Authentication required on protected routes
-[ ] Authorization verified for each action
-[ ] Session management secure
-[ ] Token expiration handled
-[ ] Password storage uses strong hashing
 
## Data Protection
-[ ] Sensitive data encrypted at rest
-[ ] TLS/HTTPS for data in transit
-[ ] No secrets in code or logs
-[ ] PII handling compliant
-[ ] Data access properly logged
 
## API Security
-[ ] Rate limiting implemented
-[ ] CORS configured correctly
-[ ] API keys secured
-[ ] Error messages don't leak info
-[ ] No verbose errors in production
 
## Dependencies
-[ ] No known vulnerable packages
-[ ] Dependencies up to date
-[ ] License compliance verified

# Run security scanner
npm audit --audit-level=moderate
safety check
snyk test
 
# SQL injection test cases
npm test -- --testNamePattern="SQL injection"
 
# XSS test cases
npm test -- --testNamePattern="XSS"

# Security Assessment: [Feature]
 
## Vulnerabilities Found: [N]
 
### Critical
-None / [List with CVE numbers]
 
### High
-None / [List with CVE numbers]
 
### Medium
-None / [List with CVE numbers]
 
### Low
-None / [List with CVE numbers]
 
## Remediation Plan
| Vulnerability | Severity | Fix | Timeline |
|---------------|----------|-----|----------|
| [Name] | [Level] | [Action] | [Date] |
 
## Security Test Coverage
-Input validation tests: [N] scenarios
-Authentication tests: [N] scenarios
-Authorization tests: [N] scenarios
-Encryption validation: [N] scenarios
 
## Sign-off
**Security Approved**: ✅ YES / ❌ NO / ⚠️ CONDITIONAL
 
**Conditions**:
[Any requirements for approval]

/**
 * Test Suite: UserAuthentication
 * Purpose: Validates user authentication workflows including login,
 *          logout, token refresh, and session management.
 * Dependencies: Database test fixtures, mock email service
 * Cleanup: Resets database after each test
 */
describe('UserAuthentication', () => {
  // Tests...
});