highflame-ai/ai-factory/reflect

/reflect — Post-Implementation Reflection

You are performing a self-review of recently implemented code to catch issues before the formal /review step. This is a fast, honest assessment of your own work.

Ethos

!sh .aif/partials/ethos-include.sh 2>/dev/null || sh ~/.claude/skills/partials/ethos-include.sh

Context

• Current branch: !git branch --show-current 2>/dev/null || echo "Not a git repo"
• Recent changes: !git diff main --stat 2>/dev/null || echo "No diff available"

Context files loaded on demand: .aif/context/conventions.md and .aif/context/architecture.md are loaded by Step 1 below — skip the Read if they are already in the current conversation (e.g., when invoked from /proceed, which preloads them at Phase 0).

Input

Scope: $ARGUMENTS

Prerequisites

Before proceeding, verify that .aif/context/conventions.md exists. If it doesn't, stop and tell the user: "The .aif/ structure hasn't been initialized. Run /init first to set up conventions."

Instructions

Step 1: Determine Scope

1. If given a REQ ID, find the associated branch and review its changes
2. If given a branch name, review all changes on that branch vs main
3. If no argument, review all changes on the current branch vs main
4. Get the full diff: git diff main...HEAD
5. Context files: if .aif/context/conventions.md and .aif/context/architecture.md are NOT already in your conversation context, Read them now. Otherwise skip — they're already loaded.

Step 2: Dispatch the reflector agent

Launch the reflector agent via the Agent tool. The agent owns the canonical self-review checklist (Correctness, Convention Compliance, Architecture, Testing, Completeness) and handles reading changed files and cross-referencing lessons learned. Keeping the checklist in the agent ensures a single source of truth that /proceed Phase 5 also uses.

Provide the agent with:

• The scope (REQ ID, branch name, or "current uncommitted changes")
• The full diff from Step 1
• conventions.md and architecture.md content (from Step 1)

Instruct it: "Read all changed files in full, grep .aif/knowledge/lessons/ for applicable lessons, run your checklist, and report findings + questions. Do not apply fixes."

The agent will return:

• Issues Found — grouped by severity (Critical / Major / Minor) with file/line, description, suggested fix
• Clean Areas — 1-2 sentences on what was checked and looked good
• Questions for the User — ambiguities, design tradeoffs, assumptions, deferred edge cases

Step 3: Present the Agent's Report

Relay the agent's Issues Found and Clean Areas sections to the user verbatim. Do not re-run the checklist yourself — that would duplicate work and risk drift.

Step 4: Surface Questions from the Agent

The reflector agent returns a "Questions for the User" block covering ambiguous requirements, design tradeoffs, assumptions made, deferred edge cases, and UX/behavioral uncertainties. Relay that block to the user as a numbered list. If the agent returned "No questions — implementation is unambiguous," state that explicitly.

Do not proceed past this step until the user has answered — their responses may change what needs to be fixed.

Step 5: Fix or Defer

1. If Critical issues are found, fix them immediately
2. If Major issues are found, ask the user whether to fix now or note for /review
3. Minor issues can be listed for the user to decide
4. After fixes, re-run tests to verify nothing broke

Step 6: Recommend Next Action

• If no issues or only minor ones: "Ready for /review"
• If fixes were applied: "Fixes applied. Re-run /reflect to verify, or proceed to /review"
• If blockers remain: "Address these issues before /review"