hivemq/hivemq-edge/pre-review

# Basic usage (analyzes current branch vs master)
/pre-review
 
# With custom base branch
/pre-review --base develop
 
# With focus areas
/pre-review --focus "state-management,testing"
 
# Skip sections
/pre-review --skip "suggestions"

git diff master...HEAD | grep -E "@ts-ignore|@ts-expect-error"

// ✅ Good
// TODO[TICKET-123]: Fix validator types to accept EntityQuery[]
// Temporary: validator expects old structure
// @ts-ignore - validator type needs update
const validator = useValidateCombiner(sources, entities)
// ❌ Bad
// @ts-ignore wrong type; need a fix
const validator = useValidateCombiner(sources, entities)

git diff master...HEAD | grep -E "eslint-disable"

// ✅ Good
// Only re-run when mapping ID changes, not when formContext updates
// to avoid cascade reconstruction
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [formData?.id])
// ❌ Bad
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [formData?.id])

git diff master...HEAD | grep -E "^\+.*console\.(log|warn|error|debug)" | grep -v "\.spec\." | grep -v "\.cy\."

git diff master...HEAD | grep -E "TODO|FIXME|XXX|HACK"

// ✅ Good
// TODO[38943/NVL]: Investigate reusing RJSF templates
// Current: manually extracting options from uiSchema
// Ideal: reuse built-in template system
// ❌ Bad
// TODO: Would prefer to reuse the templates; need investigation

// New function in src/utils/foo.ts
export const newFunction = () => {}
// Must have test in src/utils/foo.spec.ts
describe('newFunction', () => {
  it('should handle basic case', () => {})
  it('should handle edge case', () => {})
})

git diff master...HEAD | grep -E "^\+.*<(Heading|Text|Button|Label).*>.*[A-Z]" | grep -v "t\("

// ❌ Bad
const [state, setState] = useState<
  | {
      tags: DataIdentifierReference[]
      topicFilters: DataIdentifierReference[]
    }
  | undefined
>()
// ✅ Good
import type { SelectedSources } from '@/modules/Mappings/types'
const [state, setState] = useState<SelectedSources | undefined>()

// ❌ Bad
adapterId: entity.id, // ✅ Direct access to entity
// ✅ Good
adapterId: entity.id, // Direct access to entity (no index needed)

// ❌ Bad
if ((item as DomainTag).name) {
  // Check by property
}
// ✅ Good
const isDomainTag = (item: unknown): item is DomainTag => {
  return (item as DomainTag).name !== undefined
}
if (isDomainTag(item)) {
  // Type-safe check
}

git diff master...HEAD --stat | awk '{if ($3 > 300) print $1, $3}'

// src/components/NewComponent.tsx (new file)
// Must have: src/components/NewComponent.spec.cy.tsx

it('should be accessible', () => {
  cy.injectAxe()
  cy.mountWithProviders(<Component />)
  cy.checkAccessibility()  // Last test in describe block
})

// ✅ Good
cy.getByTestId('user-profile-name')
cy.findByRole('button', { name: 'Submit' })
// ❌ Bad
cy.get('.chakra-button')
cy.get('.css-abc123')

// Example: DataCombiningEditorDrawer.backward-compat.spec.cy.tsx
describe('backward compatibility', () => {
  it('should handle old data format', () => {})
  it('should handle new data format', () => {})
})

/**
 * Extracts the adapterId (scope) for a given tag from context.
 *
 * @param tagId - The tag identifier to look up
 * @param formContext - The combiner context
 * @returns The adapterId if found, undefined otherwise
 *
 * @example
 * const adapterId = getAdapterIdForTag('temperature', formContext)
 */
export const getAdapterIdForTag = (tagId: string, formContext?: CombinerContext) => {}

# Pre-Review Report: [Branch Name]
 
**Branch:** {branch-name}
**Date:** {date}
**Scope:** {files changed}, {lines added/removed}
 
---
 
## Executive Summary
 
**Overall Assessment:** [Ready/Needs Work/Major Issues]
 
**Key Strengths:**
 
-✅ ...
 
**Must Fix Before PR:**
 
-🔴 ...
 
---
 
## Critical Issues (Must Fix Before PR)
 
### 🔴 1. [Issue Title]
 
**File:** {file}:{line}
**Issue:** {description}
**Why Critical:** {reason}
**Fix Required:**
{code example}
 
---
 
## Pattern Violations (Should Fix)
 
### ⚠️ 1. [Violation Title]
 
**File:** {file}:{line}
**Pattern:** {expected pattern}
**Current:**
{code}
**Fix:**
{code}
 
---
 
## Missing Test Coverage & Quality Gates
 
### ⚠️ 1. [Missing Coverage]
 
**Missing:** {what's missing}
**Recommended:**
{code example}
 
---
 
## Suggestions (Nice to Have)
 
### 💡 1. [Suggestion Title]
 
**File:** {file}
**Suggested:** {improvement}
**Benefit:** {why}
 
---
 
## Code Quality Metrics
 
| Metric        | Score    | Status   |
| ------------- | -------- | -------- |
| Test Coverage | X files  | ✅/⚠️/❌ |
| Type Safety   | X issues | ✅/⚠️/❌ |
 
| ...
 
---
 
## Checklist Before PR Submission
 
### Critical (Must Do)
 
-[ ] Fix item 1
-[ ] Fix item 2
 
### Recommended (Should Do)
 
-[ ] Fix item 3
 
### Nice to Have (Could Do)
 
-[ ] Suggestion 1
 
---
 
## PR Description Template
 
{generated template based on changes}

critical_checks:
  - id: type-safety
    name: Type Safety Issues
    pattern: '@ts-ignore|@ts-expect-error'
    severity: critical
    rule: 'Must have justification + TODO'
 
pattern_violations:
  - id: inline-types
    name: Inline Types vs Interfaces
    severity: should-fix
    rule: 'Use explicit interfaces'
 
test_coverage:
  - id: accessibility
    name: Accessibility Tests
    severity: must-have
    rule: 'Every component needs a11y test'

// In conversation:
User: "Check if my code is ready for PR"
Assistant: [Invokes /pre-review skill]
// Or explicit:
User: "/pre-review"
Assistant: [Analyzes current branch and generates report]