intersystems-community/iris-agentic-dev/objectscript-review

Purpose

Automatically confirm generated ObjectScript follows the critical project rules before showing it to the user.

HARD GATE

Do not show ObjectScript code to the user until this review passes.

Review Checklist

For each item, check the generated code and flag any violations:

• [ ] QUIT/RETURN: No Quit <value> inside TRY/CATCH or loops
• [ ] Method calls: Intra-class calls use ..MethodName() syntax
• [ ] Error handling: Uses $$$ThrowOnError / $$$ISERR macros, not raw status checks
• [ ] THROW: Never throws a %Status directly — uses %Exception objects
• [ ] Precedence: Complex arithmetic has explicit parentheses
• [ ] Transactions: A method rolls back only its own level: Set entry=$TLevel, TSTART, then TROLLBACK:$TLevel>entry 1. A bare TROLLBACK rolls back every level, the caller's too (IRIS 2026.2)
• [ ] NEW: No New on a plain variable inside a procedure block (ERROR #1038). New $Namespace is fine: it is how a method switches namespace and gets the caller's back on exit (IRIS 2026.2)
• [ ] %TimeStamp: Uses YYYY-MM-DD HH:MM:SS format, not ISO 8601 with T
• [ ] %Status returns: Methods returning %Status use $$$OK and check with $$$ISOK/$$$ISERR
• [ ] Globals: No temporary data stored in globals when locals suffice
• [ ] Storage blocks: Never edit Storage Default { ... } — compiler auto-maps properties on compile, added or removed (orphans are fine). Rename exception: also rename its Storage entry. Reset needs explicit user confirmation.

Output Format

If violations found:

⚠️ ObjectScript review flagged [N] issues — correcting before showing:

- [rule]: [what was wrong] → [correct pattern]

Then show the corrected code.

If clean:

✅ ObjectScript review passed.

Then show the code.

Related skills

• objectscript-guardrails — all-in-one hard gate that works without MCP tools
• objectscript-tdd — compile-test-fix loop to apply after review
• objectscript-sql-patterns — load alongside this skill when writing SQL in ObjectScript