proffesor-for-testing/agentic-qe/sherlock-review

# 1. OBSERVE: Gather evidence
git diff <commit>
npm test -- --coverage
 
# 2. DEDUCE: Compare claim vs reality
# Does code match description?
# Do tests prove the fix/feature?
 
# 3. CONCLUDE: Verdict with evidence
# SUPPORTED / PARTIALLY SUPPORTED / NOT SUPPORTED

## Sherlock Investigation: [Claim]
 
### The Claim
"[What PR/commit claims to do]"
 
### Evidence Examined
-Code changes: [files, lines]
-Tests added: [count, coverage]
-Behavior observed: [what actually happens]
 
### Deductive Analysis
 
**Claim**: [specific assertion]
**Evidence**: [what you found]
**Deduction**: [logical conclusion]
**Verdict**: ✓/⚠/✗
 
### Findings
-What works: [with evidence]
-What doesn't: [with evidence]
-What's missing: [gaps in implementation/testing]
 
### Recommendations
1.[Action based on findings]

## Case: PR #123 "Fix race condition in async handler"
 
### Claims Examined:
1."Eliminates race condition"
2."Adds mutex locking"
3."100% thread safe"
 
### Evidence:
-File: src/handlers/async-handler.js
-Changes: Added `async/await`, removed callbacks
-Tests: 2 new tests for async flow
-Coverage: 85% (was 75%)
 
### Analysis:
 
**Claim 1: "Eliminates race condition"**
Evidence: Added `await` to sequential operations. No actual mutex.
Deduction: Race avoided by removing concurrency, not synchronization.
Verdict: ⚠ PARTIALLY TRUE (solved differently than claimed)
 
**Claim 2: "Adds mutex locking"**
Evidence: No mutex library, no lock variables, no sync primitives.
Verdict: ✗ FALSE
 
**Claim 3: "100% thread safe"**
Evidence: JavaScript is single-threaded. No worker threads used.
Verdict: ? NONSENSICAL (meaningless in this context)
 
### Conclusion:
Fix works but not for reasons claimed. Race condition avoided by
making operations sequential, not by adding synchronization.
 
### Recommendations:
1.Update PR description to accurately reflect solution
2.Add test for concurrent request handling
3.Remove incorrect technical claims

// Evidence-based code review
await Task("Sherlock Review", {
  prNumber: 123,
  claims: [
    "Fixes memory leak",
    "Improves performance 30%"
  ],
  verifyReproduction: true,
  testEdgeCases: true
}, "qe-code-reviewer");
// Bug fix verification
await Task("Verify Fix", {
  bugCommit: 'abc123',
  fixCommit: 'def456',
  reproductionSteps: steps,
  testBoundaryConditions: true
}, "qe-code-reviewer");

aqe/sherlock/
├── investigations/*   - Investigation reports
├── evidence/*         - Collected evidence
├── verdicts/*         - Claim verdicts
└── patterns/*         - Common deception patterns

const investigationFleet = await FleetManager.coordinate({
  strategy: 'evidence-investigation',
  agents: [
    'qe-code-reviewer',        // Code analysis
    'qe-security-auditor',     // Security claim verification
    'qe-performance-validator' // Performance claim verification
  ],
  topology: 'parallel'
});