rafaeltonholo/svg-to-compose/self-review

Self-Review

Overview

Systematically review all pending changes against this repository's standards before they are committed. Catch issues early — style violations, missing tests, broken golden samples, Detekt failures — so that PRs pass CI on the first try.

Workflow

1. Read context — Load .ai/guidelines.md and the AGENTS.md for every

module touched by the changes.

1. Enumerate changes — Run git diff (staged + unstaged) and git status

to build a complete picture of what changed.

1. Review each file against the checklist below.
2. Run verification commands to confirm nothing is broken.
3. Report findings with actionable items, grouped by severity.

Review Checklist

Code Quality

• [ ] No java.io or java.nio imports in commonMain source sets.
• [ ] File I/O uses Okio (okio.Path, okio.FileSystem), not JVM APIs.
• [ ] No new global state or singletons that could cause Kotlin/Native freezing

issues.

• [ ] Max line length is 120 characters.
• [ ] No TODO/FIXME/STOPSHIP without a linked GitHub issue.
• [ ] No hardcoded secrets, credentials, or local paths.

Architecture

• [ ] Core logic stays in commonMain; platform code in appropriate source sets.
• [ ] Build configuration uses convention plugins in build-logic/, not duplicated

in module build.gradle.kts files.

• [ ] Dependencies added to gradle/libs.versions.toml, not inlined.
• [ ] New dependencies support all targets: jvm, macosX64, macosArm64,

linuxX64, mingwX64.

Style & Conventions

• [ ] Follows kotlin.code.style=official.
• [ ] Make sure you followed SOLID principles.
• [ ] Make sure you followed DRY principle.
• [ ] Make sure you followed KISS principle.
• [ ] Make sure you followed YAGNI principle.
• [ ] Changes are minimal and focused — no unrelated refactors, no added

docstrings/comments on unchanged code.

• [ ] Public APIs you introduced must have KDocs.
• [ ] No unnecessary abstractions or over-engineering.
• [ ] Commit message follows Conventional Commits: <type>(<scope>): <subject>.
• [ ] Branch name follows <type>/<short-topic> convention.

Testing

• [ ] New or changed behavior has corresponding tests.
• [ ] Tests are in commonTest/ and mirror the source package structure.
• [ ] Tests use kotlin.test APIs with descriptive backtick names.
• [ ] Parameterized tests use Burst where appropriate.
• [ ] No flaky patterns (time-dependent, random, unordered collection assertions).

Golden Samples

• [ ] If parser or generator logic changed, golden samples were regenerated and

diffed.

• [ ] Updated golden .kt files are included in the changeset if output changed

intentionally.

• [ ] No unintended formatting or logic drift in generated output.

Static Analysis

• [ ] ./gradlew detekt passes with zero issues.
• [ ] Cognitive complexity, cyclomatic complexity, and method/class length are

within thresholds.

Verification Commands

Run these in order, stopping at the first failure to fix before proceeding:

# 1. Static analysis
./gradlew detekt detektMetadataCommonMain
 
# 2. Build
./gradlew build
 
# 3. Tests (all targets)
./gradlew allTests
 
# 4. Golden sample check (if parser/generator changed)

.github/actions/cli-integrity-check/script.sh . svg .github/actions/cli-integrity-check/script.sh . xml

require svgo to be installed

.github/actions/cli-integrity-check/script.sh . svg optimize

require avocado to be installed

.github/actions/cli-integrity-check/script.sh . xml optimize

 
## Severity Levels
 
- **Blocker** — Will fail CI or break functionality. Must fix before commit.
  Examples: Detekt failure, test failure, `java.io` in common code.
- **Warning** — Won't fail CI but degrades quality. Should fix before PR.
  Examples: Missing test for new branch, overly complex method.
- **Nit** — Minor style or readability preference. Fix if convenient.
  Examples: Slightly long line, verbose variable name.
 
## Report Format
 

Self-Review Report

Summary

<one-line summary of changes reviewed>

Blockers

• [ ] <description and file:line>

Warnings

• [ ] <description and file:line>

Nits

• [ ] <description and file:line>

Verification Results

• Detekt: PASS/FAIL
• Build: PASS/FAIL
• Tests: PASS/FAIL
• Golden samples: PASS/FAIL/N/A

 
## Completion Criteria
 
- All checklist items verified against the diff.
- All verification commands executed and passing.
- Report delivered with zero blockers remaining.