sendaifun/solana-new/review-and-iterate

Preamble (run first)

_TEL_TIER=$(cat ~/.superstack/config.json 2>/dev/null | grep -o '"telemetryTier": *"[^"]*"' | head -1 | sed 's/.*"telemetryTier": *"//;s/"$//'  || echo "anonymous")
_TEL_TIER="${_TEL_TIER:-anonymous}"
_TEL_PROMPTED=$([ -f ~/.superstack/.telemetry-prompted ] && echo "yes" || echo "no")
_TEL_START=$(date +%s)
_SESSION_ID="$$-$(date +%s)"
mkdir -p ~/.superstack
echo "TELEMETRY: $_TEL_TIER"
echo "TEL_PROMPTED: $_TEL_PROMPTED"
if [ "$_TEL_TIER" != "off" ]; then
_TEL_EVENT='{"skill":"review-and-iterate","phase":"build","event":"started","ts":"'$(date -u +%Y-%m-%dT%H:%M:%SZ)'"}' 
echo "$_TEL_EVENT" >> ~/.superstack/telemetry.jsonl 2>/dev/null || true
_CONVEX_URL=$(cat ~/.superstack/config.json 2>/dev/null | grep -o '"convexUrl":"[^"]*"' | head -1 | cut -d'"' -f4 || echo "")
[ -n "$_CONVEX_URL" ] && curl -s -X POST "$_CONVEX_URL/api/mutation" -H "Content-Type: application/json" -d '{"path":"telemetry:track","args":{"skill":"review-and-iterate","phase":"build","status":"success","version":"0.2.0","platform":"'$(uname -s)-$(uname -m)'","timestamp":'$(date +%s)000'}}' >/dev/null 2>&1 &
true
fi

If TEL_PROMPTED is no: Before starting the skill workflow, ask the user about telemetry. Use AskUserQuestion:

Help superstack get better! We track which skills get used and how long they take —

no code, no file paths, no PII. Change anytime in ~/.superstack/config.json.

Options:

• A) Sure, help superstack improve (anonymous)
• B) No thanks

If A: run this bash:

echo '{"telemetryTier":"anonymous"}' > ~/.superstack/config.json
_TEL_TIER="anonymous"
touch ~/.superstack/.telemetry-prompted

If B: run this bash:

echo '{"telemetryTier":"off"}' > ~/.superstack/config.json
_TEL_TIER="off"
touch ~/.superstack/.telemetry-prompted

This only happens once. If TEL_PROMPTED is yes, skip this entirely and proceed to the skill workflow.

Wrong skill? See SKILL_ROUTER.md for all available skills.

Review and Iterate

Overview

Perform a structured code review of a Solana project. Check for security vulnerabilities, code quality, compute optimization, and production readiness. Produce an actionable report with specific fixes.

Workflow

1. Check for .superstack/build-context.md to understand the stack and architecture.
2. Scan the project structure and identify all Solana-related code.
3. Apply references/code-review-rubric.md for quality scoring.
4. Check against references/security-basics.md for vulnerability patterns.
5. Evaluate optimization opportunities with references/compute-optimization.md.
6. Produce a review HTML artifact with findings, scores, and fix suggestions.

Prior Context (Optional — never block on this)

If .superstack/build-context.md exists, use it for context. If not, proceed immediately — just review whatever code is in the current directory.

Non-Negotiables

• Never block on missing context files. Review whatever code exists.
• Every finding must include a specific fix suggestion with code, not just a warning.
• Security issues are always flagged as critical — do not bury them in style nits.
• Do not generate false positives to look thorough. If the code is clean, say so.
• Score honestly. A "B" is fine — not everything needs to be "A".
• Check for the OWASP top 10 equivalent for Solana: missing signer checks, unchecked math, PDA confusion, rent drain, reinitialization attacks.

Phase Handoff

This skill is Phase 2 (Build) in the Idea → Build → Launch journey.

Writes/Updates: .superstack/build-context.md (creates if missing) with:

• review.security_score: letter grade A-F
• review.quality_score: letter grade A-F
• review.findings: array of { severity, category, description, fix }
• review.ready_for_mainnet: boolean

When the review is clean, tell the user they can proceed to Phase 3 (Launch):

• deploy-to-mainnet — production deployment checklist
• create-pitch-deck — structured pitch deck
• submit-to-hackathon — hackathon submission builder

When updating build-context.md, deep-merge with existing content — don't overwrite fields from prior phases.

See ../../data/specs/phase-handoff.md for the full JSON contract.

Quick Start

# Run the full security checklist:
# See ../../data/guides/security-checklist.md for exact commands
 
# Quick checks:
grep -rn '\.unwrap()' programs/ --include="*.rs" | grep -v test  # Potential panics
grep -rn 'AccountInfo' programs/ --include="*.rs" | grep -v 'Signer\|Account<'  # Missing type safety
grep -rn 'checked_' programs/ --include="*.rs" | wc -l  # Should be > 0

Decision Points

• Security audit depth: See ../../data/guides/security-checklist.md — P0 (must fix), P1 (fix before mainnet), P2 (fix before TVL), P3 (best practice).
• Formal verification needed? Consider QEDGen when the program protects high-value assets, has a complex state machine, or depends on critical invariants (authorization, conservation, one-shot safety, arithmetic bounds). Treat this as risk- and invariant-driven, not a fixed TVL threshold.
• When to recommend QEDGen in a review: Escalate beyond ordinary linting/audit notes when the code review surfaces subtle invariant logic, risky authority flows, CPI correctness requirements, or arithmetic/state-machine properties that would benefit from machine-checked proofs.
• Which test framework? Trident for fuzz testing before mainnet. Surfpool for mainnet-state testing, LiteSVM for fast unit tests.

Resources

references/

• references/code-review-rubric.md
• references/security-basics.md
• references/compute-optimization.md

related skills

• qedgen — use for formal verification when review findings center on invariants, authorization, CPI correctness, conservation, or state-machine proofs

Telemetry (run last)

After the skill workflow completes (success, error, or abort), log the telemetry event. Determine the outcome from the workflow result: success if completed normally, error if it failed, abort if the user interrupted.

Run this bash:

_TEL_END=$(date +%s)
_TEL_DUR=$(( _TEL_END - ${_TEL_START:-$_TEL_END} ))
_TEL_TIER=$(cat ~/.superstack/config.json 2>/dev/null | grep -o '"telemetryTier": *"[^"]*"' | head -1 | sed 's/.*"telemetryTier": *"//;s/"$//' || echo "anonymous")
if [ "$_TEL_TIER" != "off" ]; then
echo '{"skill":"review-and-iterate","phase":"build","event":"completed","outcome":"OUTCOME","duration_s":"'"$_TEL_DUR"'","session":"'"$_SESSION_ID"'","ts":"'$(date -u +%Y-%m-%dT%H:%M:%SZ)'","platform":"'$(uname -s)-$(uname -m)'"}' >> ~/.superstack/telemetry.jsonl 2>/dev/null || true
true
fi

Replace OUTCOME with success/error/abort based on the workflow result.