sickn33/agentic-awesome-skills/java

// ❌ Imperative accumulation
List<String> result = new ArrayList<>();
for (Item item : items) {
    if (item.isActive()) result.add(item.getName().toUpperCase());
}
 
// ✅
List<String> result = items.stream()
    .filter(Item::isActive)
    .map(item -> item.getName().toUpperCase())
    .toList(); // Java 16+; use .collect(Collectors.toList()) before

// ❌ Manual grouping
Map<String, List<Item>> grouped = new HashMap<>();
for (Item item : items) {
    grouped.computeIfAbsent(item.getCategory(), k -> new ArrayList<>()).add(item);
}
 
// ✅
Map<String, List<Item>> grouped = items.stream()
    .collect(Collectors.groupingBy(Item::getCategory));

// ❌ Manual sum
int total = 0;
for (Order o : orders) total += o.getAmount();
 
// ✅
int total = orders.stream().mapToInt(Order::getAmount).sum();

// ❌ Null check chain
String city = null;
if (user != null && user.getAddress() != null) {
    city = user.getAddress().getCity();
}
 
// ✅
String city = Optional.ofNullable(user)
    .map(User::getAddress)
    .map(Address::getCity)
    .orElse(null);

// ❌ Optional.get() without isPresent()
String name = optional.get(); // throws if empty
 
// ✅
String name = optional.orElse("default");
// or: optional.orElseThrow(() -> new IllegalStateException("name required"));

// ❌ Optional as a field or parameter (anti-pattern)
class User { private Optional<String> nickname; }
 
// ✅ — Optional is for return types only
class User { private String nickname; } // nullable field
public Optional<String> getNickname() { return Optional.ofNullable(nickname); }

// ❌ Manual POJO
class Point {
    private final int x, y;
    public Point(int x, int y) { this.x = x; this.y = y; }
    public int getX() { return x; }
    public int getY() { return y; }
    // + equals, hashCode, toString...
}
 
// ✅ (Java 16+)
record Point(int x, int y) {}

// ❌ Builder pattern for a 2-field object
User user = new User.Builder().name("Alice").age(30).build();
 
// ✅ — use record or constructor directly for small objects
record User(String name, int age) {}
var user = new User("Alice", 30);

// ❌ Switch statement with fall-through and break
String label;
switch (status) {
    case ACTIVE: label = "Active"; break;
    case INACTIVE: label = "Inactive"; break;
    default: label = "Unknown";
}
 
// ✅ (Java 14+)
String label = switch (status) {
    case ACTIVE -> "Active";
    case INACTIVE -> "Inactive";
    default -> "Unknown";
};

// ❌ instanceof + cast
if (shape instanceof Circle) {
    Circle c = (Circle) shape;
    return c.radius() * c.radius() * Math.PI;
}
 
// ✅ Pattern matching (Java 16+)
if (shape instanceof Circle c) {
    return c.radius() * c.radius() * Math.PI;
}

// ❌ Raw Thread creation
Thread t = new Thread(() -> doWork());
t.start();
 
// ✅
try (ExecutorService exec = Executors.newVirtualThreadPerTaskExecutor()) { // Java 21
    exec.submit(() -> doWork()).get(); // observe failure; declare/handle checked exceptions
}

// ❌ synchronized on this for fine-grained state
synchronized(this) { counter++; }
 
// ✅
AtomicInteger counter = new AtomicInteger();
counter.incrementAndGet();

// ❌ Catching Exception to log and swallow
try {
    risky();
} catch (Exception e) {
    log.error("error", e);
}
 
// ✅ — rethrow as unchecked if you can't handle it
try {
    risky();
} catch (IOException e) {
    throw new UncheckedIOException(e);
}

// ❌ Checked exceptions declared on every method
public void process() throws IOException, SQLException, ParseException { ... }
 
// ✅ — wrap at the boundary; internal methods throw unchecked