themadorg/madmail/fix-lint

Fix Lint

Run the repo's Makefile quality targets from the repository root and fix every failure until make lint exits 0.

Do not substitute raw cargo commands when an equivalent make target exists.

Makefile targets (authoritative)

make lint is the full gate. All compiler warnings are errors (-D warnings).

Workflow (loop until clean)

1. make fmt                    # auto-fix rustfmt issues first
2. make lint                   # full quality gate
3. Fix reported issues in code
4. make fmt                    # re-format after edits
5. make lint                   # verify
6. Repeat 3–5 until exit 0

Use make check mid-loop for a faster compile-only pass; always finish with make lint.

Parsing failures

fmt-check (first step of make lint)

Diff in /path/to/file.rs:42:

→ Run make fmt. If still failing, fix the file manually to match rustfmt.

cargo check / rustc warnings

warning: …
   --> crates/foo/src/bar.rs:10:5

→ Fix the underlying issue (unused imports, dead code, type errors, etc.). Warnings are errors via RUSTFLAGS="-D warnings".

clippy

error: …
  --> crates/foo/src/bar.rs:20:9
   = help: …
   = note: `#[deny(clippy::…)]`

→ Apply the suggested fix. Prefer the minimal change clippy hints at. Do not #[allow(...)] unless the lint is a known false positive — ask the user before suppressing.

rustdoc (cargo doc)

error: …
  --> crates/foo/src/lib.rs:5:1

→ Fix doc comments, broken intra-doc links, or missing backticks. Doc warnings are errors via RUSTDOCFLAGS="-D warnings".

Fix principles

• Minimal diffs — fix only what lint reports; no drive-by refactors.
• Match existing style — read surrounding code before editing.
• Workspace scope — make lint checks --workspace --all-targets (includes tests, benches, examples). Fix test code too.
• No warning suppression by default — resolve the root cause.
• Commit-ready — when make lint passes, summarize what was fixed.

Common fixes

What this skill does NOT cover

Quick reference

# User says "fix lint" — run this loop:
make fmt && make lint
# fix issues → make fmt && make lint
# repeat until clean

Success criterion: `make lint` exits 0 with no errors in stdout/stderr.